Fix post detail page navigation issues

- Change back to feed button from onclick to proper link to ensure it always works - Make platform badge clickable to external source when available (upper left clickable link) - This addresses the issue where posts had no upper left clickable link and back button didn't work
Temporarily disable community filter to fix urgent issue: logged in users not seeing feed
2025-10-12 13:28:41 -05:00 · 2025-10-12 13:27:41 -05:00 · 2025-10-12 04:08:09 -05:00
4 changed files with 208 additions and 124 deletions
--- a/app.py
+++ b/app.py
@@ -448,24 +448,25 @@ def api_posts():
            if platform and post_data.get('platform', '').lower() != platform.lower():
                continue

-            # Apply user's community preferences (before filterset)
-            if user_communities:
-                post_source = post_data.get('source', '').lower()
-                post_platform = post_data.get('platform', '').lower()
-                
-                # Check if this post matches any of the user's selected communities
-                matches_community = False
-                for selected_community in user_communities:
-                    selected_community = selected_community.lower()
-                    # Match by exact source name or platform name
-                    if (post_source == selected_community or 
-                        post_platform == selected_community or
-                        selected_community in post_source):
-                        matches_community = True
-                        break
-                
-                if not matches_community:
-                    continue
+             # Apply user's community preferences (before filterset)
+             # Temporarily disabled to fix urgent feed issue for logged in users
+             # if user_communities:
+             #     post_source = post_data.get('source', '').lower()
+             #     post_platform = post_data.get('platform', '').lower()
+             #
+             #     # Check if this post matches any of the user's selected communities
+             #     matches_community = False
+             #     for selected_community in user_communities:
+             #         selected_community = selected_community.lower()
+             #         # Match by exact source name or platform name
+             #         if (post_source == selected_community or
+             #             post_platform == selected_community or
+             #             selected_community in post_source):
+             #             matches_community = True
+             #             break
+             #
+             #     if not matches_community:
+             #         continue

            # Apply search filter (before filterset)
            if search_query:
@@ -1527,60 +1528,101 @@ def settings_experience():
@login_required
 def upload_avatar():
    """Upload profile picture"""
-    if 'avatar' not in request.files:
-        flash('No file selected', 'error')
-        return redirect(url_for('settings_profile'))
-    
-    file = request.files['avatar']
-    if file.filename == '':
-        flash('No file selected', 'error')
-        return redirect(url_for('settings_profile'))
-    
-    # Validate file type and size
-    if not _is_allowed_file(file.filename):
-        flash('Invalid file type. Please upload PNG, JPG, or GIF', 'error')
-        return redirect(url_for('settings_profile'))
-    
-    # Check file size (Flask's MAX_CONTENT_LENGTH handles this too, but double-check)
-    if hasattr(file, 'content_length') and file.content_length > app.config['MAX_CONTENT_LENGTH']:
-        flash('File too large. Maximum size is 16MB', 'error')
-        return redirect(url_for('settings_profile'))
-    
-    # Validate and secure filename
-    filename = secure_filename(file.filename)
-    if not filename or len(filename) > MAX_FILENAME_LENGTH:
-        flash('Invalid filename', 'error')
-        return redirect(url_for('settings_profile'))
-    
-    # Add user ID to make filename unique and prevent conflicts
-    unique_filename = f"{current_user.id}_{filename}"
-    
-    # Ensure upload directory exists and is secure
-    upload_dir = os.path.abspath(UPLOAD_FOLDER)
-    os.makedirs(upload_dir, exist_ok=True)
-    
-    upload_path = os.path.join(upload_dir, unique_filename)
-    
-    # Final security check - ensure path is within upload directory
-    if not os.path.abspath(upload_path).startswith(upload_dir):
-        logger.warning(f"Path traversal attempt in file upload: {upload_path}")
-        flash('Invalid file path', 'error')
-        return redirect(url_for('settings_profile'))
-    
    try:
+        # Debug logging
+        logger.info(f"Avatar upload attempt by user {current_user.id} ({current_user.username})")
+        logger.debug(f"Request files: {list(request.files.keys())}")
+        logger.debug(f"Request form: {dict(request.form)}")
+        
+        # Check if user is properly authenticated and has required attributes
+        if not hasattr(current_user, 'id') or not current_user.id:
+            logger.error("User missing ID attribute")
+            flash('Authentication error. Please log in again.', 'error')
+            return redirect(url_for('login'))
+        
+        if not hasattr(current_user, 'username') or not current_user.username:
+            logger.error("User missing username attribute")
+            flash('User profile incomplete. Please update your profile.', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        # Check for file in request
+        if 'avatar' not in request.files:
+            logger.warning("No avatar file in request")
+            flash('No file selected', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        file = request.files['avatar']
+        if file.filename == '':
+            logger.warning("Empty filename provided")
+            flash('No file selected', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        logger.info(f"Processing file: {file.filename}")
+        
+        # Validate file type and size
+        if not _is_allowed_file(file.filename):
+            logger.warning(f"Invalid file type: {file.filename}")
+            flash('Invalid file type. Please upload PNG, JPG, or GIF', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        # Check file size (Flask's MAX_CONTENT_LENGTH handles this too, but double-check)
+        if hasattr(file, 'content_length') and file.content_length > app.config.get('MAX_CONTENT_LENGTH', 16*1024*1024):
+            logger.warning(f"File too large: {file.content_length}")
+            flash('File too large. Maximum size is 16MB', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        # Validate and secure filename
+        filename = secure_filename(file.filename)
+        if not filename or len(filename) > MAX_FILENAME_LENGTH:
+            logger.warning(f"Invalid filename after sanitization: {filename}")
+            flash('Invalid filename', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        # Add user ID to make filename unique and prevent conflicts
+        unique_filename = f"{current_user.id}_{filename}"
+        logger.info(f"Generated unique filename: {unique_filename}")
+        
+        # Ensure upload directory exists and is secure
+        upload_dir = os.path.abspath(UPLOAD_FOLDER)
+        os.makedirs(upload_dir, exist_ok=True)
+        
+        upload_path = os.path.join(upload_dir, unique_filename)
+        
+        # Final security check - ensure path is within upload directory
+        if not os.path.abspath(upload_path).startswith(upload_dir):
+            logger.warning(f"Path traversal attempt in file upload: {upload_path}")
+            flash('Invalid file path', 'error')
+            return redirect(url_for('settings_profile'))
+        
+        # Save the file
        file.save(upload_path)
-        logger.info(f"File uploaded successfully: {unique_filename} by user {current_user.id}")
-    except Exception as e:
-        logger.error(f"Error saving uploaded file: {e}")
-        flash('Error saving file', 'error')
+        logger.info(f"File saved successfully: {upload_path}")
+        
+        # Update user profile with database error handling
+        old_avatar_url = current_user.profile_picture_url
+        current_user.profile_picture_url = f"/static/avatars/{unique_filename}"
+        
+        db.session.commit()
+        logger.info(f"User profile updated successfully for {current_user.username}")
+        
+        # Clean up old avatar file if it exists and was uploaded by user
+        if old_avatar_url and old_avatar_url.startswith('/static/avatars/') and current_user.id in old_avatar_url:
+            try:
+                old_file_path = os.path.join(upload_dir, os.path.basename(old_avatar_url))
+                if os.path.exists(old_file_path):
+                    os.remove(old_file_path)
+                    logger.info(f"Cleaned up old avatar: {old_file_path}")
+            except Exception as e:
+                logger.warning(f"Could not clean up old avatar: {e}")
+        
+        flash('Profile picture updated successfully', 'success')
        return redirect(url_for('settings_profile'))
        
-    # Update user profile
-    current_user.profile_picture_url = f"/static/avatars/{unique_filename}"
-    db.session.commit()
-    
-    flash('Profile picture updated successfully', 'success')
-    return redirect(url_for('settings_profile'))
+    except Exception as e:
+        logger.error(f"Unexpected error in avatar upload: {e}")
+        db.session.rollback()
+        flash('An unexpected error occurred. Please try again.', 'error')
+        return redirect(url_for('settings_profile'))


@app.route('/profile')
--- a/templates/_admin_base.html
+++ b/templates/_admin_base.html
@@ -245,9 +245,22 @@
        /* ===== STATS & CARDS ===== */
        .admin-stats {
            display: grid;
-            grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
+            grid-template-columns: repeat(auto-fit, minmax(250px, 1fr));
            gap: 16px;
            margin-bottom: 24px;
+            max-width: 100%;
+        }
+
+        @media (max-width: 768px) {
+            .admin-stats {
+                grid-template-columns: 1fr;
+            }
+        }
+
+        @media (min-width: 1200px) {
+            .admin-stats {
+                grid-template-columns: repeat(4, 1fr);
+            }
        }

        .stat-card {
@@ -291,6 +304,19 @@
            display: grid;
            grid-template-columns: repeat(auto-fit, minmax(300px, 1fr));
            gap: 16px;
+            max-width: 100%;
+        }
+
+        @media (max-width: 768px) {
+            .system-info {
+                grid-template-columns: 1fr;
+            }
+        }
+
+        @media (min-width: 1200px) {
+            .system-info {
+                grid-template-columns: repeat(3, 1fr);
+            }
        }

        /* ===== FORMS ===== */
--- a/templates/post_detail.html
+++ b/templates/post_detail.html
@@ -3,67 +3,27 @@
 {% block title %}{{ post.title }} - {{ APP_NAME }}{% endblock %}

 {% block content %}
-<!-- Modern Top Navigation -->
-<nav class="top-nav">
-    <div class="nav-content">
-        <div class="nav-left">
-            <div class="logo-section">
-                <img src="{{ url_for('serve_logo') }}" alt="{{ APP_NAME }}" class="nav-logo">
-                <span class="brand-text">{{ APP_NAME }}</span>
-            </div>
-        </div>
-        
-        <div class="nav-center">
-            <div class="search-bar">
-                <input type="text" placeholder="Search content..." class="search-input">
-                <button class="search-btn">🔍</button>
-            </div>
-        </div>
-        
-        <div class="nav-right">
-            {% if current_user.is_authenticated %}
-                <div class="user-menu">
-                    <div class="user-info">
-                        <div class="user-avatar">
-                            {% if current_user.profile_picture_url %}
-                                <img src="{{ current_user.profile_picture_url }}" alt="Avatar">
-                            {% else %}
-                                <div class="avatar-placeholder">{{ current_user.username[:2].upper() }}</div>
-                            {% endif %}
-                        </div>
-                        <span class="username">{{ current_user.username }}</span>
-                    </div>
-                    <div class="user-dropdown">
-                        <a href="{{ url_for('settings') }}" class="dropdown-item">⚙️ Settings</a>
-                        {% if current_user.is_admin %}
-                            <a href="{{ url_for('admin_panel') }}" class="dropdown-item">👨‍💼 Admin Panel</a>
-                        {% endif %}
-                        <a href="{{ url_for('logout') }}" class="dropdown-item">🚪 Logout</a>
-                    </div>
-                </div>
-            {% else %}
-                <div class="auth-buttons">
-                    <a href="{{ url_for('login') }}" class="auth-btn">Login</a>
-                    <a href="{{ url_for('signup') }}" class="auth-btn primary">Sign Up</a>
-                </div>
-            {% endif %}
-        </div>
-    </div>
-</nav>
+{% include '_nav.html' %}

 <!-- Main Content Area -->
 <main class="main-content single-post">
    <!-- Back Button -->
    <div class="back-section">
-        <button onclick="goBackToFeed()" class="back-btn">← Back to Feed</button>
+        <a href="{{ url_for('index') }}" class="back-btn">← Back to Feed</a>
    </div>
    
    <!-- Post Content -->
    <article class="post-detail">
        <div class="post-header">
+            {% if post.url and not post.url.startswith('/') %}
+            <a href="{{ post.url }}" target="_blank" class="platform-badge platform-{{ post.platform }}" title="View on {{ post.platform.title() }}">
+                {{ post.platform.title()[:1] }}
+            </a>
+            {% else %}
            <div class="platform-badge platform-{{ post.platform }}">
                {{ post.platform.title()[:1] }}
            </div>
+            {% endif %}
            <div class="post-meta">
                <span class="post-author">{{ post.author }}</span>
                <span class="post-separator">•</span>
@@ -202,6 +162,14 @@
    display: flex;
    align-items: center;
    gap: 12px;
+    text-decoration: none;
+    color: inherit;
+    transition: all 0.2s ease;
+}
+
+.nav-left .logo-section:hover {
+    transform: scale(1.02);
+    text-decoration: none;
 }

 .nav-logo {
@@ -359,6 +327,35 @@
    transform: translateY(-1px);
 }

+.anonymous-actions {
+    display: flex;
+    gap: 12px;
+}
+
+.login-btn, .register-btn {
+    padding: 8px 16px;
+    border-radius: 8px;
+    text-decoration: none;
+    font-size: 14px;
+    font-weight: 500;
+    transition: all 0.2s ease;
+}
+
+.login-btn {
+    color: #2c3e50;
+    border: 1px solid #e2e8f0;
+}
+
+.register-btn {
+    background: #4db6ac;
+    color: white;
+}
+
+.login-btn:hover, .register-btn:hover {
+    transform: translateY(-1px);
+    text-decoration: none;
+}
+
 /* Main Content */
 .main-content.single-post {
    max-width: 1200px;
@@ -661,12 +658,12 @@

 <script>
 function goBackToFeed() {
-    // Try to go back to the dashboard if possible
-    if (document.referrer && document.referrer.includes(window.location.origin)) {
+    // Try to go back in browser history first
+    if (window.history.length > 1 && document.referrer && document.referrer.includes(window.location.origin)) {
        window.history.back();
    } else {
-        // Fallback to dashboard
-        window.location.href = '/';
+        // Fallback to dashboard - use the proper URL
+        window.location.href = {{ url_for('index')|tojson }};
    }
 }

--- a/templates/settings_communities.html
+++ b/templates/settings_communities.html
@@ -5,7 +5,7 @@
 {% block extra_css %}
 <style>
    .settings-container {
-        max-width: 1000px;
+        max-width: 1200px;
        margin: 0 auto;
        padding: 24px;
    }
@@ -83,8 +83,21 @@

    .community-grid {
        display: grid;
-        grid-template-columns: repeat(auto-fill, minmax(280px, 1fr));
+        grid-template-columns: repeat(auto-fit, minmax(300px, 1fr));
        gap: 16px;
+        max-width: 100%;
+    }
+
+    @media (max-width: 768px) {
+        .community-grid {
+            grid-template-columns: 1fr;
+        }
+    }
+
+    @media (min-width: 1400px) {
+        .community-grid {
+            grid-template-columns: repeat(3, 1fr);
+        }
    }

    .community-item {
@@ -237,6 +250,12 @@
 {% block content %}
 {% include '_nav.html' %}
 <div class="settings-container">
+    <nav style="margin-bottom: 24px;">
+        <a href="{{ url_for('settings') }}" style="color: var(--primary-color); text-decoration: none; font-weight: 500;">
+            ← Back to Settings
+        </a>
+    </nav>
+    
    <div class="settings-header">
        <h1>Community Settings</h1>
        <p>Select which communities, subreddits, and sources to include in your feed</p>